fix: validate TEST_TMPDIR path traversal in getWritableDirs#29648
Open
Ashutosh0x wants to merge 1 commit into
Open
fix: validate TEST_TMPDIR path traversal in getWritableDirs#29648Ashutosh0x wants to merge 1 commit into
Ashutosh0x wants to merge 1 commit into
Conversation
github-actions
Bot
added
team-Local-Exec
Add validateTestTmpdir() to reject '../' traversal in TEST_TMPDIR before addWritablePath(). Add direct :pathfragment dep to BUILD. Fixes bazelbuild#29457
Ashutosh0x
force-pushed
the
fix/test-tmpdir-validation
branch
from
bb76a78 to
0e016b4
Compare
Contributor
Author
|
Hi @meteorcloudy @iancha1992 — Requesting review on this security fix. It validates TEST_TMPDIR paths in getWritableDirs to prevent path traversal outside the sandbox. Minimal change, ready for merge. Thanks! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29457
Summary
AbstractSandboxSpawnRunner.getWritableDirs()readsTEST_TMPDIRfrom the action environment and passes it directly toaddWritablePath()without validation. A malicious rule can setTEST_TMPDIRto a relative path containing../traversal sequences, causing the resolved path to escape the sandbox exec root.Root Cause
Same class of issue as #3296 (TMPDIR sanitization). The fix was partial --
TMPDIRwas sanitized butTEST_TMPDIRwas missed.TMPDIRTEST_TMPDIRFix
Added
validateTestTmpdir()usingPathFragment.containsUplevelReferences()to reject../traversal beforeaddWritablePath(). Absolute paths are allowed (legitimate via--test_tmpdir).Related