[9.1.0] Fix Unicode encoding of uploaded directories (https://github.com/bazelbuild/bazel/pull/28684)#28703
Merged
iancha1992 merged 1 commit intobazelbuild:release-9.1.0from Feb 26, 2026
Conversation
### Description Reencode internal strings to Unicode strings. ### Motivation `UploadManifest` got this right for files, but not for the contents of output directories. ### Build API Changes No ### Checklist - [x] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes Closes bazelbuild#28684. PiperOrigin-RevId: 871781011 Change-Id: Ia7aa2d746ea25ed47454797e62e68a93f4e575bc
bazel-io
added
team-Remote-Exec
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request correctly addresses the Unicode encoding issue for uploaded directories by re-encoding internal strings to Unicode strings. The new test case actionResult_unicodeDirectoryTree effectively verifies this fix. The changes are well-contained and directly target the identified problem.
tjgq
approved these changes
Feb 25, 2026
Merged
via the queue into
bazelbuild:release-9.1.0
with commit Feb 26, 2026
f24ca77
46 checks passed
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reencode internal strings to Unicode strings.
Motivation
UploadManifestgot this right for files, but not for the contents of output directories.Build API Changes
No
Checklist
Release Notes
Closes #28684.
PiperOrigin-RevId: 871781011
Change-Id: Ia7aa2d746ea25ed47454797e62e68a93f4e575bc
Commit 0449267