Deprecate and remove unused Apple-related flags and Starlark logic.#28107
Deprecate and remove unused Apple-related flags and Starlark logic.#28107dabanki wants to merge 2 commits intobazelbuild:masterfrom
Conversation
dabanki
force-pushed
the
remove_apple
branch
from
a2feff4 to
ab4ed68
Compare
github-actions
Bot
added
the
awaiting-review
|
cc @keith, @brentleyjones |
|
LGTM but appreciate a check by @keith and @brentleyjones . |
| public List<String> macosCpus; | ||
|
|
||
| @Option( | ||
| name = "catalyst_cpus", |
There was a problem hiding this comment.
not sure this one is fully dead but i don't think it was ever fully wired up either so it's probably fine
| public boolean incompatibleUseToolchainResolution; | ||
|
|
||
| @Option( | ||
| name = "apple_platforms", |
There was a problem hiding this comment.
this flag is definitely still being used by rules_apple, maybe not the one in google though
There was a problem hiding this comment.
Yeah, this was confirmed by internal owner (Nicholas Levin) that this is not used. Do you know the use case externally? Would it be possible to just leverage --platforms instead (this is what we are doing internally)? This poses complications because a List Label flag cannot natively be migrated to Starlark.
There was a problem hiding this comment.
Could a string_list flag along with https://bazel.build/rules/lib/builtins/Label#Label work?
Or similarly a custom-defined flag that does the same conversion?
There was a problem hiding this comment.
yea im sure we could, google just migrated a lot of stuff internally over the past little while in ways that require a lot of work externally in the rules. our rules aren't even close to building with 9.x right now because of that fallout
There was a problem hiding this comment.
FWIW rules_python had a similar story: the rules didn't work at all on Bazel 9 at first, at the same time we were migrating off the native flags. We and the rules_python authors collaborated to get everything in good shape.
I can't speak for the core logic changes, of course. But I hope at least the flag story doesn't further disrupt you. If there's a perpetual logic disconnect because of those flag differences, that's a good thing for us to be aware of and know how to not make things harder.
There was a problem hiding this comment.
sounds good, I added the apple_platforms flag back and I'll add it to the group of flags that need migrating.
There was a problem hiding this comment.
thanks, we can submit the PR to remove once we've updated
gregestren
added
awaiting-PR-merge
github-actions
Bot
removed
the
awaiting-PR-merge
4 participants
These flags have been identified as obsolete. We are removing their references from Bazel as precursor work towards Starlarkifying Apple related flags, eventually removing the fragment all together.
See bazelbuild/rules_apple#2845.