rules_tsickle@1.0.0#6105
Conversation
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_tsickle) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds rules_tsickle version 1.0.0 to the Bazel Central Registry. The changes are generally well-structured and follow the BCR guidelines. I have one suggestion for improvement in the MODULE.bazel file to remove redundant npm dependency declarations, which will improve the clarity and maintainability of the module definition.
fmeum
added
the
presubmit-auto-run
|
|
||
| # As an example, manually import a package using explicit coordinates. | ||
| # Just a demonstration of the syntax de-sugaring. | ||
| npm.npm_import( |
There was a problem hiding this comment.
Is this meant to be a dev dependency?
There was a problem hiding this comment.
Actually, it is not needed at all. I've cleaned up the MODULE.bazel file in stackb/rules_tsickle#4 and re-published.
pcj
force-pushed
the
rules_tsickle-v1.0.0
branch
2 times, most recently
from
39bd7ee to
c0641ca
Compare
pcj
force-pushed
the
rules_tsickle-v1.0.0
branch
from
c0641ca to
85fa09d
Compare
|
@fmeum Thanks for reviewing. This is passing now. |
Release: https://github.com/stackb/rules_tsickle/releases/tag/v1.0.0 _Automated by [Publish to BCR](https://github.com/bazel-contrib/publish-to-bcr)_ Co-authored-by: pcj <50580+pcj@users.noreply.github.com>
4 participants
Release: https://github.com/stackb/rules_tsickle/releases/tag/v1.0.0
Automated by Publish to BCR