tests: use runfiles.CreateOrRaise in release_test_helper - #4052
Merged
Conversation
Use runfiles.CreateOrRaise() in _find_real_template_path to ensure a non-None Runfiles instance and satisfy static type checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using runfiles.Create() returns an optional Runfiles object, which
can lead to typing issues and runtime attribute errors if runfiles
cannot be created or located.
Switch to runfiles.CreateOrRaise() in _find_real_template_path to
ensure a non-None Runfiles instance is returned and fail fast if
runfiles are unavailable.