Update RBE toolchain version from ubuntu2204 to ubuntu2404#3778
Update RBE toolchain version from ubuntu2204 to ubuntu2404#3778meteorcloudy wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the RBE toolchain version from Ubuntu 22.04 to 24.04 in python/private/internal_dev_deps.bzl. Feedback indicates that the WORKSPACE file should also be updated to maintain consistency and prevent CI failures for WORKSPACE-based builds.
| rbe_preconfig( | ||
| name = "buildkite_config", | ||
| toolchain = "ubuntu2204", | ||
| toolchain = "ubuntu2404", |
There was a problem hiding this comment.
The RBE toolchain version should also be updated in the WORKSPACE file (line 100) to maintain consistency between Bzlmod and WORKSPACE builds. Since the PR description mentions that support for the older platform has been dropped, failing to update WORKSPACE will likely break CI for WORKSPACE-based builds.
|
Hmm, actually ubuntu2204 should still be supported. There might be some infra breakages caused by https://github.com/bazelbuild/continuous-integration/pull/2617/changes /cc @coeuvre |
1 participant
RBE has dropped support for older platform
Fixing https://buildkite.com/bazel/rules-python-python/builds/15434#019e2c2c-c708-4c20-bc05-a9a5b1215d2f