-
-
Notifications
You must be signed in to change notification settings - Fork 657
chore: remove py_proto_library from bzlmod example #3508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove py_proto_library from bzlmod example #3508
Conversation
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the py_proto_library example from the bzlmod examples. This is a necessary cleanup since the py_proto_library rules have been removed from rules_python. The changes are comprehensive, including the deletion of all related example files and directories, as well as the removal of corresponding dependencies from MODULE.bazel and entries from .bazelignore. The changes are clean and appear to be complete. I have no specific comments on the code changes as they correctly implement the intended removal.
|
Should we remove |
py_proto_library is meant to be imported from protobuf. bazel-contrib#3508 removed the relevant examples. This PR also removes the mention in main readme.
py_proto_library is meant to be imported from protobuf. #3508 removed the relevant examples. This PR also removes the mention in main readme. cc: @rickeylev since you authored #3508
With the py_proto_library rules removed from rules_python, rules_python is no
longer the appropriate place to have examples for using the py_proto_library
rules. Having such example also causes some maintenance burden, as apparently
it incurs a nodejs dependency, which fails under newer bazel versions.
Fixes #3362