Skip to content

Fix filewatcher interrupt #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DannyBen merged 2 commits into from
Jan 6, 2026
Merged

Fix filewatcher interrupt #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3f84ae
- Fix filewatcher interrupt
DannyBen Jan 6, 2026
db07feb
remove unnecessary guard
DannyBen Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/bashly/watch.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,12 @@ def changes(modified, added, removed)
{ modified:, added:, removed: }
end

def wait
sleep
rescue ::Interrupt => e
raise Bashly::Interrupt, cause: e
end

def listen = Listen
def wait = sleep
end
end
9 changes: 9 additions & 0 deletions spec/bashly/watch_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,15 @@
end
end

context 'when the watch is interrupted' do
it 'stops the listener and re-raises as Bashly::Interrupt' do
allow(subject).to receive(:sleep).and_raise(Interrupt)

expect(listener).to receive(:stop)
expect { subject.on_change { |_| nil } }.to raise_error(Bashly::Interrupt)
end
end

context 'when no block is provided' do
it 'raises ArgumentError' do
expect { subject.on_change }.to raise_error(ArgumentError, 'block required')
Expand Down