Handle unwritable Base cache roots without tracebacks#903
Merged
Conversation
439e8ab to
3a3f8e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BASE_CACHE_DIRrecovery guidance when cache/log/temp directories cannot be created.base_clicontext creation.Issue
Fixes #895
Validation
PYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest lib/python/base_cli/tests/test_base_cli.py -q -k unwritable_cache_rootfailed withPermissionErrorescaping from context creation.PYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest lib/python/base_cli/tests/test_app_runtime_errors.py lib/python/base_cli/tests/test_base_cli.py -qPYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest lib/python/base_cli/tests -q/usr/local/bin/bash -lc "git ls-files -z '*.py' | PYTHONPATH=lib/python:cli/python xargs -0 /Users/rameshhp/.base.d/base/.venv/bin/python -m pylint --rcfile=.pylintrc"\n-BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash BASE_CACHE_DIR=/private/tmp/base-unwritable-cache-895.hSKuta bin/basectl workspace status --workspace /tmp --format jsonexits 1 with a concise error and no traceback.\n-git diff --check origin/master\n-env -u BASE_HOME BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash ./bin/base-test\n\n## Demo Impact\nNone. Runtime error handling only.\n\n## Notes\n-.ai-context/unchanged; this aligns an internal runtime failure path with existing error-reporting expectations without changing the command surface.