Make project replacement idempotent#902
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--replace-projecton an already-standard GitHub Project as a non-fatal INFO no-op instead of an error..ai-context/to clarify that already-standard Projects are left intact.Issue
Fixes #901
Validation
PYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest cli/python/base_github_projects/tests/test_project_configure_replacement.py- 5 passedPYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest cli/python/base_github_projects/tests- 30 passedBASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats cli/bash/commands/basectl/tests/gh.bats- 33 passedgit diff --checkenv -u BASE_HOME BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash ./bin/base-test- 503 passed, 1 skipped; 430 BATS passedDemo Impact
None.
Notes
The updated replacement regression test failed before the implementation with
ProjectError: Project 'base-demo' already has standard Base views; refusing to replace it.Checklist
<category>/<issue>-<YYYYMMDD>-<slug>..ai-context/, or the PR body explains why it is not applicable.Fixes #<issue>orCloses #<issue>when it should close the issue.Demo Impactis meaningful forneeds-demowork, or explicitly saysNone.