Honor uv-managed project venvs in setup and check#900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.base.d/<project>/.venvsetup/check gate.<project-root>/.venvasBASE_PROJECT_VENV_DIR.BASE-P154to report missing or ready uv project virtualenvs withuv syncguidance.Root Cause
setup_common.shstill required the legacy Base-managed project venv before invoking the Python project layer, even for manifests that explicitly declarepython.manager: uv.Validation
BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats cli/bash/commands/basectl/tests/check.bats cli/bash/commands/basectl/tests/setup.bats cli/bash/commands/basectl/tests/project-command-helpers.batsPYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest cli/python/base_setup/tests/test_uv.py -qPYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest cli/python/base_setup/tests/test_command_lint.py cli/python/base_setup/tests/test_pyproject.py -qgit diff --checkenv -u BASE_HOME BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash ./bin/base-testSmoke
basectl setup base-uv-smoke --manifest /private/tmp/base-uv-smoke/base_manifest.yaml --dry-runshowsuv syncand does not create~/.base.d/base-uv-smoke/.venv.basectl check base-uv-smoke --manifest /private/tmp/base-uv-smoke/base_manifest.yaml --format jsonreaches uv diagnostics and reportsBASE-P154withuv syncguidance. The command used a fake writableHOME, so the base prerequisite layer also reported a Homebrew Python formula error unrelated to the uv project check.Demo Impact
Fixes #896