Skip to content

Report missing project venv without a fatal trace #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeforester merged 1 commit into from
Aug 6, 2026
+6 −3
Merged

Report missing project venv without a fatal trace #1885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cli/bash/commands/basectl/subcommands/activate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,10 @@ base_activate_subcommand_main() {

venv_dir="$(base_activate_project_venv_dir "$resolved_name" "$project_root" "$route_venv_dir")"
venv_fix="$(base_project_venv_fix "$resolved_name" "$project_root" "$venv_dir" "$uses_uv_manager")"
[[ -x "$venv_dir/bin/python" ]] || {
base_std_fatal_error "Project virtual environment Python was not found at '$venv_dir/bin/python'. $venv_fix"
}
if [[ ! -x "$venv_dir/bin/python" ]]; then
base_std_log_error "Project virtual environment Python was not found at '$venv_dir/bin/python'. $venv_fix"
return 1
fi

shell_rc="$BASE_HOME/lib/bash/runtime/bashrc"
[[ -f "$shell_rc" ]] || base_std_fatal_error "Base runtime shell rcfile '$shell_rc' was not found."
Expand Down
2 changes: 2 additions & 0 deletions cli/bash/commands/basectl/tests/activate.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,8 @@ EOF
[[ "$output" == *"Project virtual environment Python was not found at '$workspace/demo/.venv/bin/python'."* ]]
[[ "$output" == *"Run 'uv sync' in '$workspace/demo' first."* ]]
[[ "$output" != *"Run 'basectl setup demo' first."* ]]
[[ "$output" != *"FATAL"* ]]
[[ "$output" != *"Encountered a fatal error"* ]]
}

@test "basectl default runtime shell preserves caller working directory" {
Expand Down
Loading