Allow configuring SMTP timeout via env vars#2393
Closed
ricekot wants to merge 1 commit intobasecamp:mainfrom
Closed
Allow configuring SMTP timeout via env vars#2393ricekot wants to merge 1 commit intobasecamp:mainfrom
ricekot wants to merge 1 commit intobasecamp:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables configuration of SMTP connection and read timeouts through environment variables, allowing users to adjust timeout behavior for their SMTP servers.
Changes:
- Added two new environment variables (SMTP_OPEN_TIMEOUT and SMTP_READ_TIMEOUT) to control SMTP timeout behavior
- Updated production environment configuration to use these new settings with 5-second defaults
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/docker-deployment.md | Documents the two new SMTP timeout environment variables with their default values |
| config/environments/production.rb | Implements the timeout configuration in the SMTP settings hash |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: ricekot <git@ricekot.com>
ricekot
force-pushed
the
smtp-timeout-config
branch
from
c443743 to
49a899d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.