Return fresh project after update#513
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a stale-response bug in the projects update command by ensuring the CLI returns the post-write project state, aligning the JSON envelope with what a subsequent projects show would return.
Changes:
- Refetch the project after
Projects().Update(...)and return the freshly fetched record. - Add a regression test that simulates a stale update response and asserts the command returns the updated
description/updated_at.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/commands/projects.go | Refetches the project after update so the response reflects the latest server state. |
| internal/commands/projects_test.go | Adds a mock-transport regression test to catch stale update responses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
projects updatebefore returning the response envelopeValidation
Reproduced on current main against Rob Zolkos test account/project: the update response returned the old description while a follow-up
projects showreturned the new description.After this change, the same live validation returns the updated description in the
projects updateresponse.Local tests:
Closes #468.
Summary by cubic
Return the fresh project after
projects updateby refetching, fixing stale fields in the response. If the refetch fails, fall back to the update response and include a diagnostic. Closes #468.Projects().Getand return that result sodescriptionandupdated_atare current.output.WithDiagnostic; tests also assert the PUT body includes the currentnamewhen onlydescriptionchanges.Written for commit eefed17. Summary will update on new commits.