feat(internal-explorer): confirm before switching explorer hosts - #93
Open
niran wants to merge 1 commit into
Open
feat(internal-explorer): confirm before switching explorer hosts#93niran wants to merge 1 commit into
niran wants to merge 1 commit into
Conversation
aws-dev cannot reach prod audit, so toggling Mainnet or Sepolia there must send the user to the prod Internal Explorer after they confirm.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BASE_UI_*_HOSTis unset). Other-host toggles open a confirm modal, thenwindow.location.assignto the destination with?chain=and other query params preserved.?chain=is missing follows the request host: zeronet onBASE_UI_ZERONET_HOST, mainnet on the mainnet/sepolia host, mainnet when hosts are unset. Explicit?chain=is never redirected on load.BASE_UI_ZERONET_HOST,BASE_UI_MAINNET_HOST,BASE_UI_SEPOLIA_HOST), matching protocols/ui#21. Same image on both deploys; noNEXT_PUBLIC_*.Test plan
npm run dev:internalwith hosts unset:/internal-explorerdefaults to Mainnet; toggling chains does not promptHost: base-ui.aws-dev.cbhq.net/internal-explorerdefaults to Zeronet;Host: base-ui.aws.cbhq.netdefaults to Mainnet?chain=mainneton aws-dev stays on aws-dev (no auto-redirect); audit for that chain is disabled there?chain=mainnetnpx vitest run app/api/internal-explorer/hosts.test.tstype=routine
risk=low
impact=sev5