Display per-tx execution time and state root time on block page#155
Merged
Display per-tx execution time and state root time on block page#155
Conversation
Use results[i].executionTimeUs (per-tx EVM time) instead of totalExecutionTimeUs, which on 0.6 is the wall-clock total_time_us that double-counts state root time. Add stateRootTimeUs from the bundle-level meter response as a separate field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
results[i].executionTimeUs(per-tx EVM time) instead oftotalExecutionTimeUsfor execution time on the block page. On 0.6,totalExecutionTimeUsis set tooutput.total_time_uswhich is the wall-clock time for the entiremeter_bundlecall — including setup, teardown, and state root — double-countingstateRootTimeUs.stateRootTimeUsfrom the bundle-level meter response as a separate field so the block page shows both execution and state root time per transaction.Context
PR #1111 in base/base fixes
totalExecutionTimeUsto be the sum of per-tx times, but it hasn't been backported to 0.6. Until 0.7 is deployed, we use the per-tx values directly. There's a TODO comment to switch back once 0.7 lands.