docs: fix broken links returning 404#1706
Open
ersinozkan1987-hub wants to merge 1 commit into
Open
Conversation
Collaborator
🟡 Heimdall Review Status
|
- thirdweb: base/demos default branch is master, /tree/main URLs return 404 - wallet_connect: extensionful signInWithEthereum.mdx link 404s on the live site - base-mentorship-program: 1kx.network/team/jakub-rusiecki page no longer exists, link to the team page like other entries
ersinozkan1987-hub
force-pushed
the
fix/broken-links
branch
from
b8499e4 to
15dd533
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Fixed three broken links that currently return 404:
base-account/framework-integrations/thirdweb: the Base Account Thirdweb Template links point tobase/demos/tree/main/..., but the default branch ofbase/demosismaster, so both links (inline +GithubRepoCard) 404. Updated to/tree/master/.base-account/reference/core/provider-rpc-methods/wallet_connect: thesignInWithEthereumlink includes the.mdxextension, which 404s on the live site (the extensionless URL works). Removed the extension.get-started/base-mentorship-program:1kx.network/team/jakub-rusieckino longer exists. Linked to the 1kx team page instead, matching how other entries in the table link to team pages.Notes to reviewers
Link-only changes, no content changes.
How has it been tested?
Verified each URL before/after with curl: