fix: remove mdBook-style .html extensions from specs overview diagram links#1697
Open
haileymarshall wants to merge 1 commit into
Open
fix: remove mdBook-style .html extensions from specs overview diagram links#1697haileymarshall wants to merge 1 commit into
haileymarshall wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
The Mermaid architecture diagrams on the protocol specs overview page contain 15 links that still use mdBook-style
.htmlpaths, left over from the specs migration (#1335). These paths don't resolve on the docs site, so every one of these links currently returns a 404:./batcher.html./bridging/withdrawals.html#the-optimism-portal-contract../reference/glossary.html#batcher-transaction./proofs/contracts.html#disputegamefactory./proofs/contracts.html#aggregateverifierThis PR drops the
.htmlextension from each href so they match the working links already used in the same diagrams (e.g../consensus/,./execution/).Notes to reviewers
hrefvalues inside the Mermaid diagrams changed; no diagram structure or prose was touched.The Optimism Portal Contract,Batcher Transaction,DisputeGameFactory,AggregateVerifier) are present in the target pages.How has it been tested?
.htmlURL returns 404 on docs.base.org and each corrected URL returns 200..htmllinks; this file was the only one remaining.