fix: correct commit hash typo in audit README#360
Open
consumeobeydie wants to merge 1 commit into
Open
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
In
audits/README.md, the commit hash displayed for the TEE Multiproof Contracts 2 audit (04/10/26) was incorrect.Before:
fe2af8cbffefa44bbb1a3917507f8bd8ebec7a2(39 characters — missing leadingf, returns 404)After:
ffe2af8cbffefa44bbb1a3917507f8bd8ebec7a2(40 characters — correct SHA, returns 200)The URL in the same row was already correct. Only the display text was wrong.
Notes to reviewers
Single character fix — the display text and the link URL pointed to different commits. The correct hash
ffe2af8cbffefa44bbb1a3917507f8bd8ebec7a2matches the adjacent row (AggregateVerifier Multiproof Contracts 2) which was audited at the same time.How has it been tested?
Verified both hashes:
ffe2af8cbffefa44bbb1a3917507f8bd8ebec7a2→ HTTP 200 ✅fe2af8cbffefa44bbb1a3917507f8bd8ebec7a2→ HTTP 404 ❌