chore: pin Foundry version for reproducible semver-lock output#283
Open
arawrdn wants to merge 1 commit into
Open
chore: pin Foundry version for reproducible semver-lock output#283arawrdn wants to merge 1 commit into
arawrdn wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GM,
Pinned the Foundry toolchain used to generate
semver-lock.Previously, the README instructed users to run:
which installs the latest Foundry version. That can change
forgebehavior, compiler metadata handling, artifact formatting, or lockfile output, causing non-deterministic diffs between local runs and CI.The fix pins Foundry installation to a specific version in CI/scripts and documents the same local setup:
solc_versionremains pinned infoundry.toml, and Foundry itself is now pinned as well. This ensuressemver-lockis generated with the same toolchain everywhere, preventing CI drift from upstream Foundry changes.Regards,