fix(active-evm): enforce multi-network task boundaries - #785
Merged
Conversation
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
Collaborator
✅ Heimdall Review Status
|
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
0xth4nh
approved these changes
Aug 20, 2026
Collaborator
|
Review Error for 0xth4nh @ 2026-08-20 18:59:27 UTC |
0xth4nh
approved these changes
Aug 20, 2026
mw2000
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADDRESSES_JSONexplicitly instead of defaulting to the shared project or task roottasks/<task-id>/config/<network>/addresses.jsonas the network-scoped deployment-address artifact pathTASK_NETWORKvisibly on every command line instead of using defaults or inherited environment valuesThis is intentionally independent of #784 so the operational Sepolia task and shared repository hardening can be reviewed and merged separately.
Verification
BASE_CONTRACTS_COMMIT=f3a33c8577c8ca1e037b45e822bfcb75f099270b make deps PROJECT_DIR="$PWD/active/evm"mise exec -- forge fmt --check script/mise exec -- forge buildgit diff --checkADDRESSES_JSONfallback