Skip to content

fix(active-evm): enforce multi-network task boundaries - #785

Merged
leopoldjoy merged 4 commits into
mainfrom
leopoldjoy/network-scoped-task-artifacts
Aug 20, 2026
Merged

fix(active-evm): enforce multi-network task boundaries#785
leopoldjoy merged 4 commits into
mainfrom
leopoldjoy/network-scoped-task-artifacts

Conversation

@leopoldjoy

@leopoldjoy leopoldjoy commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • require common verifier scripts to receive ADDRESSES_JSON explicitly instead of defaulting to the shared project or task root
  • document tasks/<task-id>/config/<network>/addresses.json as the network-scoped deployment-address artifact path
  • define one task directory as one logical operation spanning its intended network rollouts
  • require multi-network task Makefiles to select TASK_NETWORK visibly on every command line instead of using defaults or inherited environment values
  • keep one authoritative, network-agnostic root facilitator guide with explicit network placeholders
  • discourage per-network facilitator files because they duplicate configuration and drift; permit only a linked, delta-only supplement as a last resort for a materially different procedure
  • document that tasks remain active between network rollouts and are archived only after all currently intended networks finish

This is intentionally independent of #784 so the operational Sepolia task and shared repository hardening can be reviewed and merged separately.

Verification

  • BASE_CONTRACTS_COMMIT=f3a33c8577c8ca1e037b45e822bfcb75f099270b make deps PROJECT_DIR="$PWD/active/evm"
  • mise exec -- forge fmt --check script/
  • mise exec -- forge build
  • git diff --check
  • confirmed no active common-script call sites rely on the removed ADDRESSES_JSON fallback

Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
@cb-heimdall

cb-heimdall commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
@leopoldjoy leopoldjoy changed the title fix(active-evm): require network-scoped address artifacts fix(active-evm): enforce multi-network task boundaries Aug 20, 2026
leopoldjoy and others added 2 commits August 20, 2026 03:53
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
@cb-heimdall

Copy link
Copy Markdown
Collaborator

Review Error for 0xth4nh @ 2026-08-20 18:59:27 UTC
User failed mfa authentication, see go/mfa-help

@leopoldjoy
leopoldjoy merged commit 15ac105 into main Aug 20, 2026
5 checks passed
@leopoldjoy
leopoldjoy deleted the leopoldjoy/network-scoped-task-artifacts branch August 20, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants