fix: correct build-reth.sh default repo and version in README#202
Open
consumeobeydie wants to merge 1 commit into
Open
fix: correct build-reth.sh default repo and version in README#202consumeobeydie wants to merge 1 commit into
consumeobeydie wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
The
build-reth.shdescription inclients/README.mdcontained three incorrect values in the Default Configuration section that contradicted both the actual script and the Available Environment Variables section of the same README.Before:
https://github.com/paradigmxyz/reth/mainAfter:
https://github.com/ethereum-optimism/optimism/developThe script (
build-reth.sh) actually clonesethereum-optimism/optimismand buildsop-rethusing thedevelopbranch as the default. The Available Environment Variables section (lines 97–101) already documented this correctly — this PR fixes the inconsistent Default Configuration section to match.Notes to reviewers
No code changes — documentation only. Verified against
clients/build-reth.shlines 10–11.How has it been tested?
Cross-referenced
clients/build-reth.shdefaults with the corrected README values.