Skip to content

fix: correct build-reth.sh default repo and version in README#202

Open
consumeobeydie wants to merge 1 commit into
base:mainfrom
consumeobeydie:fix/build-reth-readme-incorrect-defaults
Open

fix: correct build-reth.sh default repo and version in README#202
consumeobeydie wants to merge 1 commit into
base:mainfrom
consumeobeydie:fix/build-reth-readme-incorrect-defaults

Conversation

@consumeobeydie

Copy link
Copy Markdown

What changed? Why?

The build-reth.sh description in clients/README.md contained three incorrect values in the Default Configuration section that contradicted both the actual script and the Available Environment Variables section of the same README.

Before:

  • Description: "Builds the reth binary from the Paradigm reth repository using Cargo."
  • Repository: https://github.com/paradigmxyz/reth/
  • Version: main

After:

  • Description: "Builds the op-reth binary from the Ethereum Optimism monorepo using Cargo."
  • Repository: https://github.com/ethereum-optimism/optimism/
  • Version: develop

The script (build-reth.sh) actually clones ethereum-optimism/optimism and builds op-reth using the develop branch as the default. The Available Environment Variables section (lines 97–101) already documented this correctly — this PR fixes the inconsistent Default Configuration section to match.

Notes to reviewers

No code changes — documentation only. Verified against clients/build-reth.sh lines 10–11.

How has it been tested?

Cross-referenced clients/build-reth.sh defaults with the corrected README values.

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants