Verify Denim proof parity across native SP1 and Nitro execution - #4583
Verify Denim proof parity across native SP1 and Nitro execution#45830x00101010 wants to merge 1 commit into
Conversation
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a0214a-f554-75e9-a3aa-d57ff8ad375f
|
Review: No findings This PR adds a compressed-proof generation and verification test for the Denim fixture, gated behind Reviewed:
No correctness, safety, or architectural concerns. |
|
Caution This PR may regress performance. 1 benchmark(s) slower by more than 10% beyond the noise band: Benchmark results (advisory)Median time on the PR head versus the base branch, measured on the same host. Wall-clock, so a change is only flagged when it clears ±10% and the confidence intervals do not overlap. Only benchmarks past the ±10% threshold (plus new or dropped ones) are listed. This check never blocks a merge.
46 benchmark(s) within ±10% omitted. |
🟡 Heimdall Review Status
|
Summary
Verification
just fixjust succinct test-denim-rangecargo test --locked -p base-proof-zk-backend --test denim_sp1 --no-runThe compressed cycle is intentionally not a presubmit check. Before release sign-off, dispatch the Denim SP1 workflow or run
just succinct prove-denim-range; both generate and verify the real compressed proof.Stack
Depends on #4582 (which depends on #4581).