Skip to content

fix: update cache on validation #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartventer merged 9 commits into from
Mar 12, 2026
Merged

fix: update cache on validation #27

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
871248e
fix: update cache on validation
cih9088 Jan 5, 2026
e8f96db
test: add ResponseStorer for 304
cih9088 Jan 20, 2026
307a09b
refactor: rename updateStoredHeaders to mergeResponseHeaders for clarity
bartventer Mar 12, 2026
ce2dcc1
test: add revalidation test to ensure cache updates on 304 responses
bartventer Mar 12, 2026
bb06c97
refactor(store/expapi): suppress false positive from gosec linter
bartventer Mar 12, 2026
d010c2b
chore: disable goheader check in golangci-lint
bartventer Mar 12, 2026
62e534b
Revert "chore: disable goheader check in golangci-lint"
bartventer Mar 12, 2026
890f733
Reapply "chore: disable goheader check in golangci-lint"
bartventer Mar 12, 2026
78454a0
Revert "refactor(store/expapi): suppress false positive from gosec li…
bartventer Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/validationresponsehandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ func (r *validationResponseHandler) HandleValidationResponse(
// RFC 9111 §4.3.3 Handling Validation Responses (304 Not Modified)
// RFC 9111 §4.3.4 Freshening Stored Responses upon Validation
updateStoredHeaders(ctx.Stored.Data, resp)
_ = r.rs.StoreResponse(req, ctx.Stored.Data, ctx.URLKey, ctx.Refs, ctx.Start, ctx.End, ctx.RefIndex)
Comment thread
bartventer marked this conversation as resolved.
Outdated
CacheStatusRevalidated.ApplyTo(ctx.Stored.Data.Header)
r.l.LogCacheRevalidated(req, ctx.URLKey, ctx.ToMisc(nil))
return ctx.Stored.Data, nil
Expand Down
Loading