-
Notifications
You must be signed in to change notification settings - Fork 2
fix(store/fscache): Fragment cache filenames for long URLs #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…filesystem compatibility - Introduce adaptive filename logic to split long base64-encoded URLs into directory fragments. - Retain reversibility and compatibility with previous base64 filenames. Closes #16
bartventer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approved.
|
It seems like there still is a limit for how long a URL can be. Is that correct? Can that be tunable? |
|
@eric I ran some tests to check the current limits (see #18):
Most real-world URLs are under 2KB, so this should cover typical use cases on Linux/macOS. However, Windows has stricter path limits (260 chars by default). Are you running on Windows? If so, could you share a repro? The fragment size might need platform-specific tuning for Windows compatibility. |
|
Sorry, I think I misread part of the implementation and thought there was some sort of a hard limit with the new implementation. Thank you for putting in that extra effort to confirm it performs well and doesn't have a practical limit! |
No problem! Thanks for the question, it led to good testing and benchmarking that confirmed the implementation works well. Happy to clarify anytime. |
Closes #16