ci: cover fmt, clippy, tests, doc, advisories, and MSRV#3
Merged
Conversation
Rewrites the CI workflow so the fork can stand on its own: the original
job did only fmt + build/test, which left clippy regressions, doc-link
breakage, and advisory drift to surface in PR review. The new pipeline
runs six parallel jobs sharing a Swatinem cargo cache:
- fmt cargo fmt --check
- clippy -D warnings, excluding typify-test (its codegen output
trips clippy::derivable_impls / redundant_closure; those
are codegen quality issues, not source-tree issues)
- test build + test on Linux, Windows, macOS
- doc cargo doc --no-deps -D warnings (intra-doc-link guard)
- deny cargo deny check advisories
- msrv cargo build on Rust 1.82
Adds a `deny.toml` ignore-list for four pre-existing unmaintained-crate
advisories (adler, paste, tempdir, remove_dir_all). Each entry carries
a note explaining the chain and the cleanup path; the tempdir/CVE pair
cancels automatically once cargo-typify swaps to tempfile.
Adds `#[allow(dead_code)]` to two `#[cfg(test)]` helpers in util.rs
(`all_mutually_exclusive`, `resolve`) that are currently unused but
referenced by a TODO comment to be wired back up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decisions worth flagging
Follow-ups
Test plan