Fix consent managment load by lazaki · Pull Request #78 · baloise/web-app-utils

lazaki · 2026-03-20T13:46:12Z

Closes #
Fixed consent management locale loading so it no longer defaults to German and now resolves the correct language from app/user locale settings.
Changelog
New

Added locale resolution fallback logic for consent management initialization.
Changed
Updated consent management script/config loading to use the detected locale instead of always de. - Improved language mapping/normalization handling for supported locales.

…nsuring consistent formatting

Copilot

Pull request overview

This PR aims to fix consent manager initialization so the correct locale’s consent script is loaded (and re-loaded) rather than ending up with stale/default language behavior, and updates repository automation around registry/lockfile handling.

Changes:

Update consent manager loader to de-dupe concurrent requests and remove previously injected consent-manager scripts before injecting the new locale.
Adjust root update:registry script (JFrog URL) and remove the “Update npm registry” step from CI.
Regenerate/update multiple package package-lock.json files.

Reviewed changes

Copilot reviewed 3 out of 13 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
packages/utils/src/integration/integration.ts	Adds request de-duping and script cleanup for consent manager script injection.
.github/workflows/continuous.yml	Removes the workflow step that ran `npm run update:registry`.
package.json	Updates the registry replacement URL used by `update:registry`.
packages/validators/package-lock.json	Lockfile updated; notably drops entries for internal deps.
packages/validators-vue/package-lock.json	Lockfile updated; notably drops entries for internal deps.
packages/validators-angular/package-lock.json	Lockfile updated; notably drops entries for internal deps.
packages/pipes/package-lock.json	Lockfile updated; notably drops entries for internal deps.
packages/pipes-vue/package-lock.json	Lockfile updated; notably drops entries for internal deps.
packages/pipes-angular/package-lock.json	Lockfile updated; notably drops entries for internal deps.
packages/form-vue/package-lock.json	Lockfile updated; notably drops entries for internal deps.
packages/utils/package-lock.json	Lockfile formatting update (EOF change).
packages/unsupported-browsers/package-lock.json	Lockfile updated (metadata/EOF changes).
packages/clean-architecture/package-lock.json	Lockfile formatting update (EOF change).

Files not reviewed (8)

packages/form-vue/package-lock.json: Language not supported
packages/pipes-angular/package-lock.json: Language not supported
packages/pipes-vue/package-lock.json: Language not supported
packages/pipes/package-lock.json: Language not supported
packages/unsupported-browsers/package-lock.json: Language not supported
packages/validators-angular/package-lock.json: Language not supported
packages/validators-vue/package-lock.json: Language not supported
packages/validators/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-20T13:54:14Z

packages/validators/package-lock.json

      "version": "3.17.0",
      "license": "Apache-2.0",
      "dependencies": {
-        "@baloise/web-app-utils": "^3.17.0",
        "date-fns": "^2.28.0",
        "lodash.capitalize": "^4.2.1",


package-lock.json no longer lists @baloise/web-app-utils under the root package dependencies (and its node_modules/@baloise/web-app-utils entry was removed), but packages/validators/package.json still declares @baloise/web-app-utils as a dependency. This makes the lockfile inconsistent with the manifest and can lead to incorrect installs (e.g., npm ci not installing required runtime deps). Regenerate this lockfile from the package manifest (or revert the dependency removal) so the lock reflects the declared dependencies.

Copilot · 2026-03-20T13:54:14Z

packages/pipes/package-lock.json

      "version": "3.17.0",
      "license": "Apache-2.0",
      "dependencies": {
-        "@baloise/web-app-utils": "^3.17.0",
        "lodash.capitalize": "^4.2.1",
        "lodash.isarray": "^4.0.0",


package-lock.json no longer lists @baloise/web-app-utils under the root package dependencies (and its node_modules/@baloise/web-app-utils entry was removed), but packages/pipes/package.json still declares @baloise/web-app-utils as a dependency. This makes the lockfile inconsistent with the manifest and can lead to incorrect installs. Regenerate this lockfile from the package manifest (or revert the dependency removal) so the lock reflects the declared dependencies.

Copilot · 2026-03-20T13:54:15Z

packages/validators-vue/package-lock.json

      "version": "3.17.0",
      "license": "Apache-2.0",
      "dependencies": {
-        "@baloise/web-app-validators": "^3.17.0",
        "lodash.isarray": "^4.0.0"
      },


package-lock.json no longer lists @baloise/web-app-validators under the root package dependencies (and the corresponding node_modules/@baloise/web-app-validators entry was removed), but packages/validators-vue/package.json still declares @baloise/web-app-validators as a dependency. This makes the lockfile inconsistent with the manifest and can lead to incorrect installs. Regenerate this lockfile from the package manifest (or revert the dependency removal) so the lock reflects the declared dependencies.

Copilot · 2026-03-20T13:54:15Z

packages/validators-angular/package-lock.json

      "version": "3.17.0",
      "license": "Apache-2.0",
      "dependencies": {
-        "@baloise/web-app-validators": "^3.17.0",
        "tslib": "^2.2.0"
      },


package-lock.json no longer lists @baloise/web-app-validators under the root package dependencies (and the corresponding node_modules/@baloise/web-app-validators entry was removed), but packages/validators-angular/package.json still declares @baloise/web-app-validators as a dependency. This makes the lockfile inconsistent with the manifest and can lead to incorrect installs. Regenerate this lockfile from the package manifest (or revert the dependency removal) so the lock reflects the declared dependencies.

Copilot · 2026-03-20T13:54:15Z

packages/pipes-vue/package-lock.json

@@ -8,9 +8,6 @@
      "name": "@baloise/web-app-pipes-vue",
      "version": "3.17.0",
      "license": "Apache-2.0",


The root package entry in package-lock.json no longer includes the @baloise/web-app-pipes dependency, but packages/pipes-vue/package.json still declares @baloise/web-app-pipes as a dependency. This lockfile/manifest mismatch can lead to incorrect installs. Regenerate this lockfile from the package manifest so the lock reflects the declared dependencies.

Suggested change

"license": "Apache-2.0",

"license": "Apache-2.0",

"dependencies": {

"@baloise/web-app-pipes": "^3.17.0"

},

Copilot · 2026-03-20T13:54:16Z

packages/pipes-angular/package-lock.json

      "version": "3.17.0",
      "license": "Apache-2.0",
      "dependencies": {
-        "@baloise/web-app-pipes": "^3.17.0",
        "tslib": "^2.2.0"
      },


package-lock.json no longer lists @baloise/web-app-pipes under the root package dependencies (and the corresponding node_modules/@baloise/web-app-pipes entry was removed), but packages/pipes-angular/package.json still declares @baloise/web-app-pipes as a dependency. This makes the lockfile inconsistent with the manifest and can lead to incorrect installs. Regenerate this lockfile from the package manifest (or revert the dependency removal) so the lock reflects the declared dependencies.

Copilot · 2026-03-20T13:54:16Z

packages/form-vue/package-lock.json

-        "@baloise/web-app-validators": "^3.17.0"
-      },
      "devDependencies": {
        "@baloise/design-system-components": "^10.12.0",


The root package entry in package-lock.json no longer includes the @baloise/web-app-validators dependency, but packages/form-vue/package.json still declares @baloise/web-app-validators as a dependency. This lockfile/manifest mismatch can lead to incorrect installs. Regenerate this lockfile from the package manifest so the lock reflects the declared dependencies.

Suggested change

"@baloise/design-system-components": "^10.12.0",

"@baloise/design-system-components": "^10.12.0",

"@baloise/web-app-validators": "^3.17.0",

Copilot · 2026-03-20T13:54:16Z

packages/utils/src/integration/integration.ts

 export const loadConsentManagerBaloiseSwitzerland = (lang?: Language): Promise<void> => {
-  return loadConsentManager().then((cmsData: ConsentManagerData[]) => {
+  const effectiveLang = LanguagesOfSwitzerland.valueOfOrDefault(lang ? lang.key : undefined)
+  const requestId = ++activeConsentManagerRequestId
+
+  return loadConsentManager(effectiveLang).then((cmsData: ConsentManagerData[]) => {
+    if (requestId !== activeConsentManagerRequestId) {
+      return
+    }
+


New behavior here (request de-duping via activeConsentManagerRequestId and cleanup of previously injected consent-manager scripts) is not covered by tests. Given this package already uses Jest specs (e.g. app-integration.spec.ts), it would be good to add unit tests that mock fetch and document.head to verify (1) older in-flight requests don’t inject scripts and (2) previously injected scripts are removed before injecting a new locale.

…package management

….json

…iguration

…atibility

… fix-consent-managment-load

package.json

…and package-lock.json

predrag-arsic · 2026-03-23T15:02:47Z

packages/utils/src/integration/integration.ts

+const removeInjectedConsentManagerScripts = (): void => {
+  const scripts = document.querySelectorAll(`script[${CONSENT_MANAGER_SCRIPT_ATTRIBUTE}="true"]`)
+  scripts.forEach(script => script.parentNode?.removeChild(script))
+}


Lazar Djurdjevic added 4 commits March 20, 2026 13:53

fix: improve consent manager loading and script management

ded4667

fix: update registry URL in package.json for consistency

d1111fc

fix: remove npm registry update step from CI workflow

85c350a

fix: clean up package-lock.json by removing unused dependencies and e…

e8754aa

…nsuring consistent formatting

lazaki requested review from hirsch88, nobilo and yannickholzenkamp as code owners March 20, 2026 13:46

lazaki requested review from Copilot, nobilo and yannickholzenkamp and removed request for hirsch88, nobilo and yannickholzenkamp March 20, 2026 13:46

Copilot started reviewing on behalf of lazaki March 20, 2026 13:47 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Lazar Djurdjevic added 15 commits March 20, 2026 14:55

fix: add hasInstallScript property to package-lock.json for improved …

ce8ad01

…package management

fix: remove npm registry update step from release workflow

6e1daee

fix: fix package-lock.json

ec90e6b

fix: update lerna configuration and add workspaces support in package…

b27960e

….json

fix: add npm registry update step to release and continuous workflows

d533e32

fix: remove workspaces support and update package paths in lerna conf…

7ff600d

…iguration

fix: update node version and setup-node action in continuous workflow

d04c27e

fix: update TypeScript and Jest versions, adjust tsconfig settings

d74a4d3

fix: update rollup configuration and dependencies for Angular 17 comp…

9afbec0

…atibility

chore(): update build artifacts

cf6685e

chore(release): publish v3.17.1

1327cf0

fix: update Jest tests to use jest.spyOn and add jsdom test environment

0c070ce

Merge remote-tracking branch 'origin/fix-consent-managment-load' into…

c199a87

… fix-consent-managment-load

fix: update Jest tests to use jest.spyOn and add jsdom test environment

0a41593

chore(): update build artifacts

7a0a0f3

chore(release): publish v3.17.2

9abf5a8

nobilo reviewed Mar 23, 2026

View reviewed changes

package.json Outdated Show resolved Hide resolved

nobilo self-assigned this Mar 23, 2026

fix: remove unnecessary engine and override fields from package.json …

8c1cc8a

…and package-lock.json

lazaki assigned lazaki and unassigned nobilo Mar 23, 2026

lazaki requested review from FilipMarkovski, arsic-aleksandar, girafi and predrag-arsic March 23, 2026 14:55

predrag-arsic reviewed Mar 23, 2026

View reviewed changes

lazaki requested review from baengel and svene March 23, 2026 15:02

nobilo approved these changes Mar 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix consent managment load#78

Fix consent managment load#78
lazaki wants to merge 21 commits intomasterfrom
fix-consent-managment-load

lazaki commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Uh oh!

predrag-arsic Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	"@baloise/design-system-components": "^10.12.0",
	"@baloise/design-system-components": "^10.12.0",
	"@baloise/web-app-validators": "^3.17.0",

Conversation

lazaki commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

predrag-arsic Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants