Conversation
|
Deploy preview for babel ready! Built with commit b6e9cab |
xtuc
left a comment
xtuc
left a comment
There was a problem hiding this comment.
Could you please use the embeded YouTube URL instead?
The videos doesn't show up because of "Refused to display '' in a frame because it set 'X-Frame-Options' to 'sameorigin'."
|
Addressed that. |
|
Question: One of the videos has two authors, but the videos page assumes one author per video AFAIK. Would a new PR adding that be interesting? |
There was a problem hiding this comment.
looks good.
for later:
fine with figuring out how to add multiple authors. Maybe we should remove the .yml and use a js object like in the users page PR.
Also with this many videos it seems to load slowly so maybe we only show the first recent few (or that's just how it goes)?
|
Yeah async loading the videos seem better, as well as fixing CSS layout (via flex or grid) so that things align properly should be good followups. |
|
I have started working on a yml-based solution for multiple authors. Maybe I can port that to js? Can you link to the PR you mention, @hzoo, so that I can have a look? |
|
#1834 this PR is way more since it basically is rewriting it, but like you can just convert the yml into JSON and then JS probably? |
Re: #1849 This allows displaying two authors for the same talk. It also changes the data format for videos from yml to js.
5 participants
Closes #1767
I've tried to dig all the info from the video links. Please do revise.