chore(main): pin opentdf dependencies & fix new ruff issues#128
Conversation
Fixes 9 FURB10 errors across 4 files
Summary of ChangesHello @b-long, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintenance and code quality improvements by updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the ruff pre-commit hook to version v0.15.0 and applies stylistic fixes, primarily replacing if-else expressions with the more idiomatic or operator for improved code readability. While these stylistic changes are correct and contribute to good repository maintenance, a critical security vulnerability was identified in the KAS URL handling logic. The SDK trusts KAS URLs provided in TDF manifests without validation, leading to a potential OIDC token leak via SSRF. This vulnerability needs to be addressed by implementing a strict allow-list for KAS URLs or validating them against the configured platform URL.
- pins otdfctl to v0.28.0 - pins platform to service/v0.8.2
e2695a1 to
418e395
Compare
Fixes 9 instances of https://docs.astral.sh/ruff/rules/if-exp-instead-of-or-operator/