fix: stop trimming the odd queuer under strict EvenTeams

[FrancescoBorzi]

Summary by CodeRabbit

• New Features

  • Improved battleground queue matching by allowing complete verified groups to enter the queue, including odd-sized solo groups.
  • Added configurable handling for game masters, AFK players, auras, queue announcements, decline hints, and automatic opt-out after repeated declines.

• Bug Fixes

  • Queue eligibility now consistently respects battleground bracket assignments.
  • Updated startup status reporting to reflect current cross-faction queue settings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 679340c2-0a5b-4b5d-a5a1-b9109444c859

📥 Commits

Reviewing files that changed from the base of the PR and between 0759baa and 28550af.

📒 Files selected for processing (2)

• src/BgAutoQueue.cpp
• src/BgAutoQueue.h

---

📝 Walkthrough

Walkthrough

BgAutoQueue no longer derives strict EvenTeams mode from configuration or trims verified buckets for parity. Startup logging and queueing documentation are updated, and new private skip, broadcast, decline, and opt-out settings are declared.

Changes

Even-teams queue behavior

Layer / File(s)	Summary
Configuration and queueing contract src/BgAutoQueue.h, src/BgAutoQueue.cpp	CFBG handling and startup logging now use _cfbgEnabled without _evenTeamsStrict; queueing comments clarify bracket-based viability and queue-time skips, while new private settings are declared.
Full verified-bucket queueing src/BgAutoQueue.cpp	QueueBucket no longer applies strict EvenTeams parity trimming and queues the complete verified bucket, including an odd solo.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• azerothcore/mod-bg-auto-queue#13: Directly overlaps the _evenTeamsStrict configuration and parity-trimming behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: removing the odd-player trim under strict EvenTeams.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/keep-odd-queuer

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR adjusts battleground auto-queue behavior to stop deferring (“parity trimming”) an odd extra player under strict cross-faction EvenTeams, allowing the entire verified bucket to be queued and letting the matcher invite an even subset while leaving the odd player queued as backfill.

Changes:

• Removed strict EvenTeams parity-trimming logic from QueueBucket, so odd-sized verified groups/solos are still queued.
• Simplified config mirroring/logging by dropping the mirrored CFBG.EvenTeams.Enabled/_evenTeamsStrict tracking.
• Updated header and inline comments to reflect the new queueing behavior and rationale.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/BgAutoQueue.h	Updates API/member comments and removes _evenTeamsStrict member to align with new queueing behavior.
src/BgAutoQueue.cpp	Removes parity-trim logic in QueueBucket and removes config/log plumbing for strict EvenTeams tracking.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.