fix: improve '.bgevents' status feedback

[FrancescoBorzi]

Summary by CodeRabbit

• New Features
  • The battleground auto-queue status command now shows clearer, player-facing eligibility messages and the reason when auto-queueing is unavailable.
  • Status output now distinguishes between queue eligibility, opt-out state, and whether scheduled events are currently active.
• Bug Fixes
  • Improved consistency in queue checks so players receive a single, accurate eligibility result and bracket-related failures are handled cleanly.

[coderabbitai]

Warning

Review limit reached

@FrancescoBorzi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 14 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 60a25133-c202-4dcf-8695-94e8531dab79

📥 Commits

Reviewing files that changed from the base of the PR and between 0c45f96 and 6209e1c.

📒 Files selected for processing (2)

• src/BgAutoQueue.cpp
• src/BgAutoQueue.h

📝 Walkthrough

Walkthrough

The change centralizes queue eligibility and battleground bracket resolution in IsQueueEligible. Queue processing and .bgevents status reporting now use this helper, with player-facing messages for specific skip reasons.

Changes

Queue eligibility and status reporting

Layer / File(s)	Summary
Shared eligibility and bracket resolution src/BgAutoQueue.h, src/BgAutoQueue.cpp	Adds IsQueueEligible to combine eligibility checks, bracket lookup, skip reasons, and bracket output, then uses it during queue passes.
Player-facing eligibility status src/cs_bg_auto_queue.cpp	Updates .bgevents output for scheduling state and player eligibility, with messages mapped from each SkipReason.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• azerothcore/mod-bg-auto-queue#13: Refactors overlapping BgAutoQueue eligibility and skip-handling paths.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: improving .bgevents status feedback.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-status-feedback

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR improves the .bgevents player-facing status output by reporting actual auto-queue eligibility (including bracket resolution) and by providing clearer reasons when auto-queueing is unavailable, while also deduplicating queue-pass eligibility logic in BgAutoQueue.

Changes:

• Updated .bgevents (no-arg) to show eligibility vs. scheduled-event state separately and to provide a specific per-player ineligibility reason.
• Introduced BgAutoQueue::IsQueueEligible() to unify “pass-time eligibility” checks (including the reference-map bracket check) and reused it in RunQueuePass().
• Added player-facing skip-reason messaging distinct from operator-oriented labels.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/cs_bg_auto_queue.cpp	Reworks .bgevents status messaging and adds player-facing skip-reason strings.
src/BgAutoQueue.h	Exposes a new public IsQueueEligible() API to share queue-pass eligibility logic.
src/BgAutoQueue.cpp	Implements IsQueueEligible() and uses it to simplify/standardize RunQueuePass() filtering.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.