fix: add descriptive error message to SendBatchOperationFailedException#1624
Open
Baqirrizvidev wants to merge 1 commit into
Open
fix: add descriptive error message to SendBatchOperationFailedException#1624Baqirrizvidev wants to merge 1 commit into
Baqirrizvidev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #1605 by constructing a detailed, descriptive exception message when creating a
SendBatchOperationFailedException.Problem
Previously, in
AbstractMessagingTemplate.handleFailedSendBatch, aSendBatchOperationFailedExceptionwas created with a hardcoded empty string""as the exception message. As a result,e.getMessage()returned"", rendering the exception silent in logs and requiring developers to manually extract details viae.getSendBatchResult().failed().Solution
This PR updates
AbstractMessagingTemplateto dynamically construct a diagnostic error message when a batch send operation fails. The message now contains:Testing
shouldThrowIfHasFailedMessagesInBatchByDefaultunit test inSqsTemplateTeststo verify thatSendBatchOperationFailedExceptioncontains a message with the expected queue name, failed message ID, and SQS error details.