Correct cache io_size metric type to histogram#1738
Merged
sahityadg merged 2 commits intoawslabs:mainfrom Jan 13, 2026
Merged
Conversation
passaro
approved these changes
Jan 9, 2026
Until this change, these are incorrectly recorded as counters and do not capture the request size distribution for cache requests Signed-off-by: Sahitya Damera <sahityad@amazon.com>
Signed-off-by: Sahitya Damera <sahityad@amazon.com>
e50c0cc to
5aa0f78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until this change, these are incorrectly recorded as counters, which do not help capture the bytes get/put to cache.
Does this change impact existing behavior?
Yes, Changes how these metrics are recorded in logs.
Does this change need a changelog entry? Does it require a version change?
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).