Skip to content

Correct cache io_size metric type to histogram#1738

Merged
sahityadg merged 2 commits intoawslabs:mainfrom
sahityadg:fix-cache-io-size-metric
Jan 13, 2026
Merged

Correct cache io_size metric type to histogram#1738
sahityadg merged 2 commits intoawslabs:mainfrom
sahityadg:fix-cache-io-size-metric

Conversation

@sahityadg
Copy link
Copy Markdown
Contributor

Until this change, these are incorrectly recorded as counters, which do not help capture the bytes get/put to cache.

Does this change impact existing behavior?

Yes, Changes how these metrics are recorded in logs.

Does this change need a changelog entry? Does it require a version change?

Yes


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@sahityadg sahityadg had a problem deploying to PR integration tests January 8, 2026 18:33 — with GitHub Actions Failure
@sahityadg sahityadg temporarily deployed to PR integration tests January 8, 2026 18:43 — with GitHub Actions Inactive
Until this change, these are incorrectly recorded as counters and do not
capture the request size distribution for cache requests

Signed-off-by: Sahitya Damera <sahityad@amazon.com>
Signed-off-by: Sahitya Damera <sahityad@amazon.com>
@sahityadg sahityadg force-pushed the fix-cache-io-size-metric branch from e50c0cc to 5aa0f78 Compare January 9, 2026 18:10
@sahityadg sahityadg temporarily deployed to PR integration tests January 9, 2026 18:10 — with GitHub Actions Inactive
@sahityadg sahityadg marked this pull request as ready for review January 9, 2026 18:10
@sahityadg sahityadg enabled auto-merge January 9, 2026 18:10
@sahityadg sahityadg added this pull request to the merge queue Jan 9, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 9, 2026
@sahityadg sahityadg added this pull request to the merge queue Jan 13, 2026
Merged via the queue into awslabs:main with commit af24802 Jan 13, 2026
50 checks passed
@sahityadg sahityadg deleted the fix-cache-io-size-metric branch January 13, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants