Conversation
Add two GitHub Actions workflows triggered on PRs to main: - js-lint: runs ESLint and Prettier on changed frontend files using project-local config and dependencies - python-lint: runs ruff check and ruff format on changed Python files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kaleko
approved these changes
Mar 10, 2026
Contributor
kaleko
left a comment
kaleko
left a comment
There was a problem hiding this comment.
Merging, but some future things to note or consider improving:
-
tj-actions/changed-files@v46 — This is a third-party action. It's pinned to a major version tag (v46) rather than a commit SHA. For a security-conscious project, you'd ideally pin to a full SHA (e.g., tj-actions/changed-files@)
to prevent supply chain attacks if the tag gets moved. This is a moderate concern. -
Node 18 is EOL — The JS workflow uses node-version: '18'. Node 18 reached end-of-life in April 2025. Should be bumped to 20 or 22. Worth checking what the frontend's package.json specifies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm ciinstead of global installs.ts,.tsx,.js,.jsx,.css,.json,.mjsfilescontinue-on-error: trueso lint failures actually fail the workflowfrontend/working directory using project ESLint and Prettier configuvto install and run ruff.pyfilesBoth workflows use
envvariables forchanged-filesoutput to prevent script injection.