fix(http): use user-provided ClientBootstrap in HttpConnection

[abhu85]

Summary

Fix condition that checked uninitialized options.bootstrap (always null after AWS_ZERO_STRUCT) instead of connectionOptions.Bootstrap. This caused user-provided ClientBootstrap to never be used.

Changes

• Changed line 136 in source/http/HttpConnection.cpp from checking options.bootstrap to connectionOptions.Bootstrap

Test plan

• Code review passed
• Build tests (requires CMake + submodules setup)

Fixes #819

[abhu85]

Friendly ping for review. This is a 1-line fix for #819 where the user-provided ClientBootstrap was being ignored due to checking the wrong variable (options.bootstrap which is always null after AWS_ZERO_STRUCT instead of connectionOptions.Bootstrap).

[abhu85]

Friendly follow-up. This 1-line fix has been open for 6 weeks now.

CI Note: The CodeBuild integration test failure appears unrelated to this change - it's an AWS internal test and all 64 GitHub Actions checks pass (including thread/address sanitizers).

Related: I noticed PR #840 adds a test case HttpCreateConnectionCustomBootstrapRespected that verifies the user-provided bootstrap is respected - which is exactly what this PR fixes. Would it make sense to merge this fix first so that test passes, or is there a different approach being taken?

Happy to rebase or make any adjustments needed.

[azkrishpy]

Hi @abhu85 I am working on this PR. The draft PR was only to ensure the test actually fails and the commit is added as part of this PR. Working on the integration test and will be merged soon. Thank you for your contribution!