fix(serve): pre-deploy JumpStart benchmark data + public HuggingFace download helper - #6175
Open
ZealSV wants to merge 1 commit into
Open
fix(serve): pre-deploy JumpStart benchmark data + public HuggingFace download helper#6175ZealSV wants to merge 1 commit into
ZealSV wants to merge 1 commit into
Conversation
ZealSV
force-pushed
the
fix/pysdk-benchmark-configs-hf-helper
branch
from
August 10, 2026 23:21
2c28d8f to
6032115
Compare
Lokiiiiii
suggested changes
Aug 11, 2026
…download helper Fixes ModelBuilder benchmark APIs for pre-deploy JumpStart models and adds a public HuggingFace-Hub download helper: - benchmark_metrics: display_benchmark_metrics() read self.benchmark_metrics, a property that existed in v2 but was dropped in the v3 port, so it raised AttributeError. Restore the property (a pandas DataFrame built from the model's published deployment-config benchmark data). - list_deployment_configs(): with no instance_type it called _get_deployment_configs() before the JumpStart metadata configs were loaded, so a pre-deploy builder (_metadata_configs=None) got []. _get_deployment_configs now calls _ensure_metadata_configs() itself, so every caller lazily loads them. - ragged benchmark data: get_metrics_from_deployment_configs built columns independently, appending the instance-rate (pricing) column only for instances that had it. That produced unequal-length columns (crashing pd.DataFrame with "All arrays must be of the same length") AND misaligned the present rate values onto the wrong rows. Assemble one record per row and pivot to columns at the end, padding unset cells with None, so columns stay equal length and every value stays on its own row. Column layout is unchanged (the rate column still comes last). - download_huggingface_model(): new public helper in serve.utils.hf_utils, exported from sagemaker.serve. Downloads a Hub snapshot and optionally uploads it to S3, so notebooks no longer hand-roll snapshot_download + S3Uploader. Supports revision / allow_patterns / ignore_patterns passthroughs; when staging to S3 without a caller-supplied local_dir it uses a temporary directory that is removed after the upload. migration.md documents both new surfaces. Unit: 11 new tests (benchmark/config, ragged-metrics alignment/order, HF helper incl. temp-dir cleanup and passthroughs).
ZealSV
force-pushed
the
fix/pysdk-benchmark-configs-hf-helper
branch
from
August 11, 2026 19:34
6032115 to
31956b7
Compare
ZealSV
requested a deployment
to
manual-approval
August 11, 2026 19:37 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
ZealSV
requested a deployment
to
manual-approval
August 11, 2026 19:37 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
ZealSV
requested a deployment
to
manual-approval
August 11, 2026 19:37 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues with ModelBuilder benchmark APIs for pre-deploy JumpStart models, plus adds a public HuggingFace-Hub download helper:
benchmark_metrics: display_benchmark_metrics() read self.benchmark_metrics, a property that existed in v2 but was dropped in the v3 port, so it raised AttributeError. Restore the property (a pandas DataFrame built from the model's published deployment-config benchmark data).
list_deployment_configs(): with no instance_type it called _get_deployment_configs() without first loading the JumpStart metadata configs, so a pre-deploy builder (_metadata_configs=None) got []. Added _ensure_metadata_configs() into _get_deployment_configs so every caller (listing and benchmark data) lazily loads them.
download_huggingface_model(): new public helper in serve.utils.hf_utils, exported from sagemaker.serve. Downloads a Hub snapshot and optionally uploads it to S3, so notebooks no longer hand-roll snapshot_download + S3Uploader. The previous downloader was a method on a private class and not importable.
Unit: 11 new tests (6 benchmark/config, 5 HF helper).
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.