You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
Hi. Are you sure you want to pin exactly to numpy==2 in pyproject.toml? This is bound to create a lot of incompatibilities in downstream usage. Better to relax the constraint a bit IMHO.
Hi. Are you sure you want to pin exactly to numpy==2 in pyproject.toml? This is bound to create a lot of incompatibilities in downstream usage. Better to relax the constraint a bit IMHO.
Agreed, that isn't the right thing to do. Currently in master a range of versions is supported (numpy>=1.9.0,<2). The best goal is to drop or increase the <2 part of that; so move to numpy>=1.9.0,<3 or numpy>=1.9.0,<2.5. This should not be too difficult, almost every other widely used project with a dependency on numpy has been able to do this. Typically what works in 2.0 also works in 1.2x. Worst case you may need some if-else constructs like https://numpy.org/devdocs/numpy_2_0_migration_guide.html#writing-numpy-version-dependent-code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.