fix(security): 2 improvements across 1 files#1999
Open
tomaioo wants to merge 1 commit into
Open
Conversation
- Security: Information Disclosure in Error Handling - Security: Potential Sensitive Header Logging Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 1 files
Problem
Severity:
Medium| File:packages/graph-explorer-proxy-server/src/error-handler.ts:L79The
extractErrorInfofunction returnserror.messagedirectly for genericErrorinstances. If an unexpected internal error occurs (e.g., database driver crash, file system error), internal implementation details, stack traces, or sensitive context could be leaked to the client in the HTTP response.Solution
For generic
Errorinstances (500 status codes), return a generic message like "Internal Server Error" to the client, and log the actualerror.messageinternally. Only expose specific messages for expectedHttpErrorinstances.Changes
packages/graph-explorer-proxy-server/src/error-handler.ts(modified)