fix: show a friendly Access denied message for 403 responses#1979
Open
vishwakt wants to merge 1 commit into
Open
fix: show a friendly Access denied message for 403 responses#1979vishwakt wants to merge 1 commit into
vishwakt wants to merge 1 commit into
Conversation
A 403 previously fell through to the catch-all NetworkError branch, showing the unfriendly "Network Response 403" title with either the raw server response or a generic message. Since a 403 can be caused by several things (credentials, permissions, proxy configuration), the new message stays generic and points the user at what they can reasonably check. Fixes aws#1977
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1977
403 responses fell through to the catch-all
NetworkErrorbranch, showing "Network Response 403" with the raw server response. Added a dedicated 403 branch with the copy from the issue. The message stays generic since a 403 can mean credentials, permissions, or proxy configuration. The raw response is still available via Error Details.Tested against a local stub returning a Neptune-style
AccessDeniedException403, triggered via schema sync.Before:
After: