Add FTP Capacity Block Expiration Notification Feature#144
Draft
jatinkulkarni wants to merge 2 commits intoaws:mainfrom
Draft
Add FTP Capacity Block Expiration Notification Feature#144jatinkulkarni wants to merge 2 commits intoaws:mainfrom
jatinkulkarni wants to merge 2 commits intoaws:mainfrom
Conversation
FTP Capacity Block Expiration Notification
arkaprava08
reviewed
Feb 18, 2026
Comment on lines
+10
to
+15
| +// Capacity Block notification constants | ||
| +export const THIRTY_MINUTES_INTERVAL_MILLIS = 30 * 60 * 1000; | ||
| +export const TEN_MINUTES_INTERVAL_MILLIS = 10 * 60 * 1000; | ||
| +export const TWO_MINUTES_INTERVAL_MILLIS = 2 * 60 * 1000; | ||
| +export const EC2_THIRTY_MINUTES_SHUTDOWN_MILLIS = 30 * 60 * 1000; | ||
| +export const CB_EXTENSION_TOLERANCE_MILLIS = 1 * 60 * 1000; // 1 minute tolerance for CB extension detection |
There was a problem hiding this comment.
Please remove hardcoded contants and read from env variables or atleast fall back to. This would make the IDE logic very rigid
arkaprava08
reviewed
Feb 18, 2026
| sagemaker/sagemaker-ui-dark-theme.diff | ||
| sagemaker/sagemaker-ui-post-startup.diff | ||
| sagemaker/sagemaker-extension-smus-support.diff | ||
| sagemaker/sagemaker-extension-cb-notification.diff |
There was a problem hiding this comment.
Why can't we move under sagemaker-extension rather than creating a new one? Also can we make the client side logic generic while pushing the notifications from backend?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of Changes
Implements FTP Capacity Block Expiration Notification feature for SageMaker extension. Adds three-tier notification system (30min, 10min, 2min warnings) to alert users before capacity block expiration, preventing unexpected data loss.
Key additions:
Technical highlights:
Testing
Tested via GitHub Actions workflow on feature branch with DISABLE_MANGLE=true. Build artifacts generated successfully. Verified notification scheduling logic and timeout handling.
Screenshots/Videos
Additional Notes
Changes limited to SageMaker-specific directories (patches/sagemaker/), enabling SageMaker team self-approval per CODEOWNERS. Feature enhances UX by preventing data loss during capacity block expiration with defensive error handling and graceful degradation.
Backporting
Consider backporting to supported version branches (1.0.x, 1.1.x) if needed for existing SageMaker deployments.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.