Merged
Conversation
| "@vscode/iconv-lite-umd": "0.7.1", | ||
| - "@vscode/ripgrep": "^1.15.13", | ||
| "@vscode/vsce": "3.6.1", | ||
| + "@vscode/vsce-sign": "file:../../../../build-tools/vsce-sign", |
Contributor
There was a problem hiding this comment.
Do we also need to add the vsce-sign binary to this path? Currently there's nothing present in this path.
Contributor
Author
There was a problem hiding this comment.
Yes, vsce-sign is needed on code editor gitfarm only. And it is added here so that the patches will be in sync on both repositories
| "dependencies": { | ||
| - "vscode-languageclient": "^10.0.0-next.15", | ||
| - "vscode-languageclient": "^10.0.0-next.18", | ||
| + "vscode-languageclient": "10.0.0-next.9", |
Contributor
There was a problem hiding this comment.
Why are we lowering the version here?
Contributor
Author
There was a problem hiding this comment.
These have been downgraded only because npmpm had an issue with allowlisting packages. It seems to have been resolved, so I will remove this override
added 2 commits
February 18, 2026 13:05
This reverts commit 5ce945f.
sachinh-amazon
approved these changes
Feb 18, 2026
Contributor
|
Let's also add this to the |
feiyangliu2023
added a commit
to feiyangliu2023/code-editorv2
that referenced
this pull request
Feb 18, 2026
* resolve internal patch conflicts and adopt custom built vsce-sign * correct usage of untar in gulp * Remove outdated version upgrade * Revert "Remove outdated version upgrade" This reverts commit 5ce945f. --------- Co-authored-by: Feiyang Liu <lfeiyang@amazon.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
D372376902
Description of Changes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.