Skip to content

Fix string converter null in map #6737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RanVaknin wants to merge 3 commits into
base: master
Choose a base branch
from
+21 −2
Open

Fix string converter null in map #6737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f235a51
Add test showcasing the issue
RanVaknin Feb 13, 2026
50d9583
Add null handling in convertMap
RanVaknin Feb 13, 2026
a9b370d
Remove unused import
RanVaknin Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...mazon/awssdk/enhanced/dynamodb/internal/converter/attribute/StringAttributeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,14 @@ public String convertMap(Map<String, AttributeValue> value) {
};

return value.entrySet().stream()
.collect(Collectors.toMap(Map.Entry::getKey, i -> toString(i.getValue()),
throwingMerger, LinkedHashMap::new))
.collect(Collectors.toMap(
Map.Entry::getKey,
i -> {
String converted = toString(i.getValue());
return converted == null ? "null" : converted;
},
throwingMerger,
LinkedHashMap::new))
.toString();
}

Expand Down
13 changes: 13 additions & 0 deletions ...e/amazon/awssdk/enhanced/dynamodb/converters/attribute/StringAttributeConvertersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
import software.amazon.awssdk.enhanced.dynamodb.internal.converter.attribute.UuidAttributeConverter;
import software.amazon.awssdk.enhanced.dynamodb.internal.converter.attribute.ZoneIdAttributeConverter;
import software.amazon.awssdk.enhanced.dynamodb.internal.converter.attribute.ZoneOffsetAttributeConverter;
import software.amazon.awssdk.services.dynamodb.model.AttributeValue;
import software.amazon.awssdk.utils.ImmutableMap;

public class StringAttributeConvertersTest {
Expand Down Expand Up @@ -254,4 +255,16 @@ public void stringSetAttributeConverter_ReturnsSSType() {
SetAttributeConverter<Set<String>> converter = SetAttributeConverter.setConverter(StringAttributeConverter.create());
assertThat(converter.attributeValueType()).isEqualTo(AttributeValueType.SS);
}

@Test
public void stringAttributeConverter_convertsMapWithNullValue() {
StringAttributeConverter converter = StringAttributeConverter.create();

String result = transformTo(converter, fromMap(ImmutableMap.of(
"stringField", AttributeValue.builder().s("value").build(),
"nullField", AttributeValue.builder().nul(true).build())));

assertThat(result).contains("stringField=value");
assertThat(result).contains("nullField=null");
}
}