Added 0 check before writeThroughpt calculation to prevent divide bytes written by 0#6734
Open
Added 0 check before writeThroughpt calculation to prevent divide bytes written by 0#6734
Conversation
alextwoods
approved these changes
Feb 13, 2026
This reverts commit 4745297.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation and Context
WRITE_THROUGHPUT metric is calculated to Double.Infinity, which cannot be emitted to EMF and is not true. This happen because when first byte time and last byte time are the same, we are dividing bytes written by 0.
Modifications
Added 0 check before bytespersec is invoked for writethroughpt
Testing
Added test case.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License