Open
Conversation
Changes: - Add an additional job in Integ testing CI workflow to run the integration tests with Apache 5 - Update the patch so it applies cleanly after some removals - Add a -v to the apply command to make apply issues easy to see in failed CodeBuild builds - Update the policy statement used by one of the DDB integ tests because Apache 5.6 included new usage of setOption.
dagnir
force-pushed
the
dongie/integ-test-apache5-update
branch
from
ce98153 to
12a9cc5
Compare
dagnir
commented
Feb 11, 2026
| permission "java.lang.RuntimePermission" "accessDeclaredMembers"; | ||
| permission "javax.net.ssl.SSLPermission" "setDefaultSSLContext"; | ||
| permission "java.net.SocketPermission" "*", "connect,resolve"; | ||
| permission "jdk.net.NetworkPermission" "*", "setOption."; |
Contributor
Author
There was a problem hiding this comment.
Apache5 uses this new API. https://github.com/apache/httpcomponents-client/blob/d8d09ed89605cbd41d759fab2626bba561602ed0/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/DefaultHttpClientConnectionOperator.java#L338-L340
This didn't get exercised previously because we were integ testing with a very old version of JDK8 that didn't have these APIs
|
joviegas
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Ensure we integ test with Apache 5.
Modifications
Changes:
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License