Use partitions.json to generate PartitionMetadata classes#6694
Merged
S-Saranya1 merged 7 commits intomasterfrom Feb 14, 2026
Merged
Use partitions.json to generate PartitionMetadata classes#6694S-Saranya1 merged 7 commits intomasterfrom
S-Saranya1 merged 7 commits intomasterfrom
Conversation
davidh44
reviewed
Jan 30, 2026
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "type": "feature", | |||
| "category": "AWS SDK for Java v", | |||
Contributor
There was a problem hiding this comment.
Suggested change
| "category": "AWS SDK for Java v", | |
| "category": "AWS SDK for Java v2", |
| private static final String ID = "aws"; | ||
|
|
||
| private static final String NAME = "AWS Standard"; | ||
| private static final String NAME = "aws"; |
Contributor
There was a problem hiding this comment.
Any reason for this change?
Contributor
Author
There was a problem hiding this comment.
Fixed this, added a display naming mapping since partitions.json doesn't have this field, keeping the public API behavior same.
davidh44
approved these changes
Feb 11, 2026
alextwoods
approved these changes
Feb 12, 2026
...te/src/main/java/software/amazon/awssdk/codegen/lite/regions/PartitionMetadataGenerator.java
Outdated
Show resolved
Hide resolved
alextwoods
approved these changes
Feb 13, 2026
| } | ||
|
|
||
| private void validateDualStackDnsSuffix(String dualStackDnsSuffix) { | ||
| if (dualStackDnsSuffix == null) { |
Contributor
There was a problem hiding this comment.
Nit: Maybe check empty as well as null (StringUtils.isBlank)
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate PartitionMetadata code generation from endpoints.json to partitions.json.
Motivation and Context
Currently, PartitionMetadata classes are being generated from endpoints.json. Endpoints.json is legacy and adds latency during client initialization, this PR migrates PartitionMetadataGenerator to use partitions.json as the data source instead.
Modifications
Testing