Skip to content

added another check for ENABLE_ZLIB_REQUEST_COMPRESSION=OFF #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kai-ion merged 5 commits into from
Feb 3, 2026
Merged

added another check for ENABLE_ZLIB_REQUEST_COMPRESSION=OFF #3704

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40cdc20
added a check for NOT ENABLE_ZLIB_REQUEST_COMPRESSION STREQUAL "OFF"
kai-ion Jan 28, 2026
eb8be70
Merge branch 'main' into compresss
kai-ion Feb 2, 2026
707c339
Merge branch 'main' into compresss
kai-ion Feb 2, 2026
935da88
Merge branch 'main' into compresss
kai-ion Feb 3, 2026
a5ad5be
Merge branch 'main' into compresss
kai-ion Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmake/external_dependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@
if(PLATFORM_ANDROID AND ANDROID_BUILD_ZLIB)
set(BUILD_ZLIB 1)
message(STATUS " Building Zlib as part of AWS SDK")
elseif(NOT PLATFORM_WINDOWS AND NOT PLATFORM_CUSTOM)
#If zlib is required either by openssl and curl in their linking chain, we should find it.
# If ENABLE_ZLIB_REQUEST_COMPRESSION is OFF, zlib check is skipped entirely
elseif(NOT PLATFORM_WINDOWS AND NOT PLATFORM_CUSTOM AND
NOT ENABLE_ZLIB_REQUEST_COMPRESSION STREQUAL "OFF")
# If zlib is required either by openssl and curl in their linking chain, we should find it.
include(FindZLIB)
if(NOT ZLIB_FOUND)
message(FATAL_ERROR "Could not find zlib")
Expand Down