chore(integration): bump cryptography to 46.0.6#8892
chore(integration): bump cryptography to 46.0.6#8892EhteshamSid wants to merge 3 commits intoaws:developfrom
Conversation
0eea2bc to
f2b00de
Compare
f2b00de to
6baf6cc
Compare
There was a problem hiding this comment.
Changes look good, are there any more places that would require an update to the cryptography version? I'm not understanding why it's just tests/integration/testdata/buildcmd/asset.b998895901bf33127f2c9dce715854f8b35aa73fb7eb5245ba9721580bbe5837/requirements.txt.
Another example of a place with an old version is here:
|
Thanks for the review! To answer your question about the other files: The The The Let me know if you'd like any of the other fixture files updated as well - happy to do so if that's preferred. |
|
I don't think the 3.3.2 version is necessarily intentional, just a long time since it was updated 😅. I also don't see the difference between the CDK generated requirements file and the one that I linked before, both should get installed in the buildcmd tests via Also I'd like to note that there are some linting errors in the CI. You can test those locally by running |
|
Fair point - updated all the remaining |
60c6abe to
1fa1643
Compare
fcbc60e to
f3468cf
Compare
A few dependencies in the requirements file have CVEs fixed in newer versions:
cryptography46.0.5 -> 46.0.6 (CVE-2026-34073)requests2.32.5 -> 2.33.0 (CVE-2026-25645)Bumped each one to the minimum safe version.
There's a mutable default argument in
samcli/lib/sync/infra_sync_executor.py. The default value is shared across all calls that don't pass that argument, so mutations in one call silently affect the next. Changed the default toNonewith anif arg is Noneguard inside the function.Changed files:
samcli/lib/sync/infra_sync_executor.py,samcli/local/lambdafn/remote_files.py,tests/integration/durable_integ_base.py,tests/integration/local/start_api/test_start_api.py,tests/integration/logs/test_logs_command.pyand 8 more