[Test] In test_slurm_rest_api, remove the custom action meant to patch the Slurm build as it is not necessary anymore#7386
Draft
gmarciani wants to merge 1 commit intoaws:developfrom
Conversation
…h the Slurm build as we have now fixed the build and it is no longer necessary.
gmarciani
changed the title
gmarciani
added
skip-changelog-update
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7386 +/- ##
===========================================
+ Coverage 90.07% 90.09% +0.01%
===========================================
Files 182 183 +1
Lines 16732 16749 +17
===========================================
+ Hits 15072 15090 +18
+ Misses 1660 1659 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
In test_slurm_rest_api, remove the custom action meant to patch the Slurm build as we have now fixed the build and it is no longer necessary.
Why not removing the script
rebuild_slurm.shfrom the test config folder since it is now unused?Just because it is practical to have at hand the custom action to to patch slurm for future issues, ready to be used in an end2end test.
Tests
PENDING
test_slurm_rest_apiBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.