[Test] Fix test_slurm_custom_partitions: use instance type defined in test config#7375
Open
gmarciani wants to merge 1 commit intoaws:developfrom
Open
[Test] Fix test_slurm_custom_partitions: use instance type defined in test config#7375gmarciani wants to merge 1 commit intoaws:developfrom
gmarciani wants to merge 1 commit intoaws:developfrom
Conversation
gmarciani
added
skip-changelog-update
…ype in job constraint. _test_active_job_running hardcoded "c5.xlarge" as the Slurm constraint, causing failures when the test runs with a different instance type.
gmarciani
force-pushed
the
wip/mgiacomo/3160/custom-slurm-part-0504-1
branch
from
fbe3655 to
e4d4324
Compare
gmarciani
changed the title
himani2411
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix test_slurm_custom_partitions so that it uses the parameterized instance type in job constraint rather than hard coded one. This fix is useful to prevent failures when we run the test with an instance type that is not c5.xlarge.
Tests
SUCCESS
test_slurm_custom_partitionsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.