Add LaunchTemplateOverrides support for compute resources#7228
Draft
hanwen-cluster wants to merge 3 commits intoaws:developfrom
Draft
Add LaunchTemplateOverrides support for compute resources#7228hanwen-cluster wants to merge 3 commits intoaws:developfrom
hanwen-cluster wants to merge 3 commits intoaws:developfrom
Conversation
617eda4 to
826a5b1
Compare
58e8ded to
de2f1d0
Compare
Allow customers to specify LaunchTemplateOverrides with a LaunchTemplateId and Version at the compute resource level. This enables customers to customize RunInstances parameters (e.g. NetworkInterfaces) that are not directly exposed by ParallelCluster config, without requiring changes to the ParallelCluster codebase for each new parameter.
The launch template data is fetched, transformed into run_instances_overrides.json (keyed by queue/compute resource name), and uploaded to the cluster S3 bucket. The file is always uploaded (empty {} when no overrides) to cleanly handle cluster update transitions.
de2f1d0 to
724ed6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Allow customers to specify LaunchTemplateOverrides with a LaunchTemplateId and Version at the compute resource level. This enables customers to customize RunInstances parameters (e.g. NetworkInterfaces) that are not directly exposed by ParallelCluster config, without requiring changes to the ParallelCluster codebase for each new parameter.
The launch template data is fetched, transformed into run_instances_overrides.json (keyed by queue/compute resource name), and uploaded to the cluster S3 bucket. The file is always uploaded (empty {} when no overrides) to cleanly handle cluster update transitions.
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.